-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use validated config for logging in #2927
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4bcdd9b
to
9f20960
Compare
d9e5ed2
to
8a4ec95
Compare
This breaks changing the homeserver on the fly and autodiscovery by MXID intentionally. Future commits will fix that, however for now they have been intentionally disabled for simplicity.
Known broken things are entering "https://matrix.org" doesn't switch you to FREE and Modular configuration doesn't work at this stage.
8a4ec95
to
472318e
Compare
Replacing this PR with something more manageable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config parsing is done in element-hq/element-web#9496, this is mostly implementation and actual usage of it.
TODO: Try and split this into smaller chunks
See element-hq/element-web#9290