Override font for usercontent download link #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
May 29, 2019
|
Going to merge and prepare the release version. |
jryans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9867
The download link in encrypted rooms is rendered in an iframe, with all (inherited) styles from the app applied to the inline style of the link. So font-family is copied over, including Nunito and the (native) emoji fonts. None of the webfonts are loaded though, so it will fallback to the first native font that can render a glyph, which appears to be the emoji font for numbers.
Ideally we'd render the link in Nunito, but that would be a bit more involved, so override the font-family to Arial, ... which was the font the link was rendered with in practice in the past.