Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sbix fallback twemoji font (and bump to emoji 12) #3050

Merged
merged 5 commits into from Jun 3, 2019
Merged

add sbix fallback twemoji font (and bump to emoji 12) #3050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
caa950f
add SBIX fallback twemoji font
ara4n Jun 2, 2019
1abd3db
add extra ligatures
ara4n Jun 2, 2019
16ca31b
lint
ara4n Jun 2, 2019
e8d8eee
fix ligatures fully
ara4n Jun 2, 2019
f9d4094
upgrade to twemoji 12.0.4
ara4n Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file modified res/fonts/Twemoji_Mozilla/TwemojiMozilla-colr.woff2
View file
Open in desktop
Binary file not shown.
Binary file added res/fonts/Twemoji_Mozilla/TwemojiMozilla-sbix.woff2
View file
Open in desktop
Binary file not shown.
8 changes: 7 additions & 1 deletion src/utils/FontManager.js
View file
Open in desktop
Expand Up @@ -114,7 +114,13 @@ export async function fixupColorFonts() {
// weights for the emoji to appear in bold messages, etc.
document.fonts.add(new FontFace("Twemoji", path, { weight: 600 }));
document.fonts.add(new FontFace("Twemoji", path, { weight: 700 }));
} else {
// fall back to SBIX, generated via https://github.com/matrix-org/twemoji-colr/tree/matthew/sbix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's very unfortunate that we're not able to use upstream for this. I have many fears about us forgetting to upgrade, or falling behind, or otherwise not maintaining our fork very well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, but i see no alternative sadly.

const path = `url('${require("../../res/fonts/Twemoji_Mozilla/TwemojiMozilla-sbix.woff2")}')`;
document.fonts.add(new FontFace("Twemoji", path, {}));
document.fonts.add(new FontFace("Twemoji", path, { weight: 600 }));
document.fonts.add(new FontFace("Twemoji", path, { weight: 700 }));
}
// if not supported, the browser will fall back to one of the native fonts specified.
// ...and if SBIX is not supported, the browser will fall back to one of the native fonts specified.
}