Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer IM token until widget is shown and permission granted #3240

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Defer IM token until widget is shown and permission granted #3240

merged 1 commit into from
Jul 22, 2019

Commits on Jul 22, 2019

  1. Defer IM token until widget is shown and permission granted 

    This defers the work to request the IM token when displaying a widget until
after we know that widget will actually be shown and the user has granted
permission for this widget to be displayed.

This is useful in general to avoid making unnecessary token checks, but it's
particularly helpful with the new Terms API, so that we only show the Terms flow
when widget are actually being used (as opposed to entering the room where
widgets exist, but haven't been shown / permitted).

Part of element-hq/element-web#10088
    @jryans
    jryans committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    09c2d89 View commit details
    Browse the repository at this point in the history