Warn on disconnecting from IS #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...if the user has bound threepids Fixes element-hq/element-web#10550
jryans
approved these changes
Aug 15, 2019
| @@ -0,0 +1,52 @@ | |||
| /* | |||
There was a problem hiding this comment.
Maybe BoundThreepids.js with capital B would be more consistent?
There was a problem hiding this comment.
so nominally the ones with capitals are classes and the small-letter ones are collections of functions. This may not be the best naming convention / way of organising though.
There was a problem hiding this comment.
Hmm, I see. Should it be bound-threepids.js or boundThreepids.js then? Seems unclear. Anyway, I guess doesn't need to be solved here.
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...if the user has bound threepids
Fixes element-hq/element-web#10550