Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New composer: format bar tooltips #3387

Merged
merged 4 commits into from
Sep 6, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Sep 5, 2019

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm based on pull/3386/head...pull/3387/head - except copyright mentioned on commit

In future, please at least merge the base branch into the PR branch - this helps make it a clean merge and gives a waypoint for where to start reviewing things. Your git tree would look something like this:
image

@bwindels
Copy link
Contributor Author

bwindels commented Sep 6, 2019

In future, please at least merge the base branch into the PR branch - this helps make it a clean merge and gives a waypoint for where to start reviewing things. Your git tree would look something like this:

Oh, good tip! will do next time.

@bwindels bwindels force-pushed the bwindels/cider-formatbar-tooltips branch from 48a8167 to 042822c Compare September 6, 2019 08:39
@bwindels bwindels merged commit de787c7 into develop Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants