Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings A11Y tweaks #3475

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Settings A11Y tweaks #3475

merged 5 commits into from
Sep 25, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 25, 2019

Should fix/improve element-hq/element-web#10901

  • Helps screen readers understand disabled AccessibleButtons
  • Allows tabbing through ToggleSwitches
  • Allows screen readers to understand ToggleSwitches as checkboxes with active/inactive state and label
  • Helps screen readers understand the close button on a Dialog

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…rix-org/matrix-react-sdk into t3chguy/accesibility
@t3chguy t3chguy requested a review from a team September 25, 2019 16:15
@turt2live
Copy link
Member

@t3chguy video/gif please

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise (please have a video to show that the thing is at least keyboard accessible)

src/components/views/elements/ToggleSwitch.js Outdated Show resolved Hide resolved
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member Author

t3chguy commented Sep 25, 2019

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants