Make "remove recent messages" more robust #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
force-pushed
the
bwindels/redact-all-more-robust
branch
from
84f00a3
to
5a487f3
Compare
t3chguy
reviewed
Oct 3, 2019
bwindels
force-pushed
the
bwindels/redact-all-more-robust
branch
from
5a487f3
to
fcd4cb5
Compare
|
Branch needs to be rebased to make e2e tests pass? Looks like cider-by-default wasn't applied yet by the last run of the e2e tests. |
bwindels
force-pushed
the
bwindels/redact-all-more-robust
branch
from
fcd4cb5
to
6bb303c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: element-hq/element-web#10972
Requires: matrix-org/matrix-js-sdk#1048
This just gets all the timelines known, and looks for events from the user in each, as opposed to going back through the links between individual timelines. The linked bug seemed to indicate that those links sometimes might get corrupted, and while this won't fix the timeline issues that result from that, it might make "remove recent messages" a bit more robust.