Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cross-signing feature flag #3626

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Add cross-signing feature flag #3626

merged 2 commits into from
Nov 18, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Nov 18, 2019

@jryans jryans requested a review from a team November 18, 2019 16:08
turt2live
turt2live approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooi, how did this get through in the first place without a feature flag?

@jryans
Copy link
Collaborator Author

jryans commented Nov 18, 2019

ooi, how did this get through in the first place without a feature flag?

Well, it's (mostly) not wired up to anything so far... The JS SDK bits that have landed define new APIs only called by tests so far.

Unless you mean device verification, which has been chaining off the existing user info feature flag I think... it's getting a bit complicated. 😅

@turt2live
Copy link
Member

it's getting a bit complicated.

just a bit

@jryans jryans merged commit 31b2d26 into develop Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cross-signing feature flag
2 participants
@jryans @turt2live