Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of FTUE user lists design #3792

Merged
merged 4 commits into from
Jan 3, 2020

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 3, 2020

Review with element-hq/element-web#11758

This covers the "recents" section and rough design exclusively. It is known that the Field does nothing and that there's a bunch of missing functionality - this is to be iterated upon in future PRs. Labs flag is to aide development and should be removed in a very near future PR.

Also, this is focusing on DMs and not user lists in general because I misinterpreted the scope. I'll fix this in a future PR and instead make this the best DM invite dialog it can be.

Closes element-hq/element-web#11197

This covers the "recents" section and rough design exclusively. It is known that the Field does nothing and that there's a bunch of missing functionality - this is to be iterated upon in future PRs. Labs flag is to aide development and should be removed in a very near future PR.

Also, this is focusing on DMs and not user lists in general because I misinterpreted the scope. I'll fix this in a future PR and instead make this the best DM invite dialog it can be.

Closes element-hq/element-web#11197
turt2live added a commit to element-hq/element-web that referenced this pull request Jan 3, 2020
@turt2live turt2live requested a review from a team January 3, 2020 00:59
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, thanks! 😁

src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
src/components/views/dialogs/DMInviteDialog.js Outdated Show resolved Hide resolved
@turt2live turt2live merged commit 65954b1 into develop Jan 3, 2020
@turt2live turt2live deleted the travis/ftue/user-lists/1-initial branch January 3, 2020 17:32
@turt2live
Copy link
Member Author

I apparently never included a screenshot:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recent DMs to Invite/Create DM dialog
2 participants