Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on unverified/unknown devices. #3837

Merged
merged 4 commits into from Jan 14, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jan 13, 2020

When cross-signing is enabled, we no longer want to fail and
prompt the user to ack every device in the room. All the info should
be conveyed in the shield colour (although isn't fully just yet).

Fixes element-hq/element-web#11750
Requires matrix-org/matrix-js-sdk#1150

When cross-signing is enabled, we no longer want to fail and
prompt the user to ack every device in the room. All the info should
be conveyed in the shield colour (although isn't fully just yet).

Fixes element-hq/element-web#11750
Requires matrix-org/matrix-js-sdk#1150
@dbkr dbkr requested a review from a team January 13, 2020 17:44
@dbkr dbkr changed the title Don't error on unverifie/unknownd devices. Don't error on unverified/unknown devices. Jan 13, 2020
@jryans jryans requested review from jryans and removed request for a team January 14, 2020 12:29
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update unknown device warning logic
2 participants