Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for timeline in pre-join UISI path #3972

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jan 29, 2020

Somehow, live events can be missing a timeline, even though that should not
happen... This restores @uhoreg's previous version where we test for this case.

Fixes element-hq/element-web#12120

Somehow, live events can be missing a timeline, even though that should not
happen... This restores @uhoreg's previous version where we test for this case.

Fixes element-hq/element-web#12120
@jryans jryans requested a review from uhoreg January 29, 2020 12:01
@jryans
Copy link
Collaborator Author

jryans commented Jan 29, 2020

I'm very sorry about this @uhoreg, I was so sure this would not happen while reviewing #3881. 😭

Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test sending in an encrypted room, and it worked, so I don't know why it didn't work for Bruno. 🤷‍♂️

@jryans jryans merged commit c0e88be into develop Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't send message in encrypted room
2 participants