Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: make alternative addresses UX less confusing #4221

Merged
merged 10 commits into from
Mar 17, 2020
Merged

Fix: make alternative addresses UX less confusing #4221

merged 10 commits into from
Mar 17, 2020

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Mar 16, 2020 •
edited

@bwindels bwindels changed the title Bwindels/aliaslipstick Fix: make alternative addresses UX less confusing Mar 16, 2020
@bwindels
Copy link
Contributor Author

bwindels commented Mar 16, 2020 •
edited

Ahh, the e2ee tests are failing, will fix tomorrow. Build was just cancelled.

@bwindels bwindels added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Mar 16, 2020
@bwindels bwindels requested a review from a team March 16, 2020 17:31
@bwindels bwindels requested a review from nadonomy March 17, 2020 09:48
nadonomy
nadonomy approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jryans
jryans approved these changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! 😄

src/components/views/room_settings/AliasSettings.js Outdated Show resolved Hide resolved
bwindels and others added 2 commits March 17, 2020 10:43
@bwindels @jryans
Update src/components/views/room_settings/AliasSettings.js
1f4e928 
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
@bwindels
run i18n
0106612
@bwindels bwindels mentioned this pull request Mar 17, 2020
Merged
@bwindels bwindels merged commit e8c7754 into develop Mar 17, 2020
@luixxiul luixxiul mentioned this pull request May 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
3 participants
@bwindels @jryans @nadonomy