Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull multi-inviting functionality out of MultiInviteDialog #467

Merged
merged 4 commits into from Sep 13, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Invite.js
Expand Up @@ -15,6 +15,7 @@ limitations under the License.
*/

import MatrixClientPeg from './MatrixClientPeg';
import MultiInviter from './utils/MultiInviter';

const emailRegex = /^\S+@\S+\.\S+$/;

Expand Down Expand Up @@ -44,6 +45,20 @@ export function inviteToRoom(roomId, addr) {
}
}

/**
* Invites multiple addresses to a room
* Simpler interface to utils/MultiInviter but with
* no option to cancel.
*
* @param {roomId} The ID of the room to invite to
* @param {array} Array of strings of addresses to invite. May be matrix IDs or 3pids.
* @returns Promise
*/
export function inviteMultipleToRoom(roomId, addrs) {
this.inviter = new MultiInviter(roomId);
return inviter.invite(addrs);
}

export function isValidAddress(addr) {
// Check if the addr is a valid type
var addrType = this.getAddressType(addr);
Expand Down
144 changes: 144 additions & 0 deletions src/utils/MultiInviter.js
@@ -0,0 +1,144 @@
/*
Copyright 2016 OpenMarket Ltd

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

import {getAddressType, inviteToRoom} from '../Invite';
import q from 'q';

/**
* Invites multiple addresses to a room, handling rate limiting from the server
*/
export default class MultiInviter {
constructor(roomId) {
this.roomId = roomId;

this.canceled = false;
this.addrs = [];
this.busy = false;
this.completionStates = {}; // State of each address (invited or error)
this.errorTexts = {}; // Textual error per address
this.deferred = null;
}

/**
* Invite users to this room. This may only be called once per
* instance of the class.
*
* The promise is given progress when each address completes, with an
* object argument with each completed address with value either
* 'invited' or 'error'.
*
* @param {array} addresses Array of addresses to invite
* @returns {Promise} Resolved when all invitations in the queue are complete
*/
invite(addrs) {
if (this.addrs.length > 0) {
throw new Error("Already inviting/invited");
}
this.addrs.push(...addrs);

for (const addr of this.addrs) {
if (getAddressType(addr) === null) {
this.completionStates[addr] = 'error';
this.errorTexts[addr] = 'Unrecognised address';
}
}
this.deferred = q.defer();
this._inviteMore(0);

return this.deferred.promise;
}

/**
* Stops inviting. Causes promises returned by invite() to be rejected.
*/
cancel() {
if (!this.busy) return;

this._canceled = true;
this.deferred.reject(new Error('canceled'));
}

getCompletionState(addr) {
return this.completionStates[addr];
}

getErrorText(addr) {
return this.errorTexts[addr];
}

_inviteMore(nextIndex) {
if (this._canceled) {
return;
}

if (nextIndex == this.addrs.length) {
this.busy = false;
this.deferred.resolve(this.completionStates);
return;
}

const addr = this.addrs[nextIndex];

// don't try to invite it if it's an invalid address
// (it will already be marked as an error though,
// so no need to do so again)
if (getAddressType(addr) === null) {
this._inviteMore(nextIndex + 1);
return;
}

// don't re-invite (there's no way in the UI to do this, but
// for sanity's sake)
if (this.completionStates[addr] == 'invited') {
this._inviteMore(nextIndex + 1);
return;
}

inviteToRoom(this.roomId, addr).then(() => {
if (this._canceled) { return; }

this.completionStates[addr] = 'invited';
this.deferred.notify(this.completionStates);

this._inviteMore(nextIndex + 1);
}, (err) => {
if (this._canceled) { return; }

let errorText;
let fatal = false;
if (err.errcode == 'M_FORBIDDEN') {
fatal = true;
errorText = 'You do not have permission to invite people to this room.';
} else if (err.errcode == 'M_LIMIT_EXCEEDED') {
// we're being throttled so wait a bit & try again
setTimeout(() => {
this._inviteMore(nextIndex);
}, 5000);
return;
} else {
errorText = 'Unknown server error';
}
this.completionStates[addr] = 'error';
this.errorTexts[addr] = errorText;
this.busy = !fatal;

if (!fatal) {
this.deferred.notify(this.completionStates);
this._inviteMore(nextIndex + 1);
}
});
}
}