Match fuzzy filtering a bit more reliably in the new room list #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
Jun 16, 2020
|
|
||
| // Note: we have to match the filter with the removeHiddenChars() room name because the | ||
| // function strips spaces and other characters (M becomes RN for example, in lowercase). | ||
| // We also doubly convert to lowercase to work around oddities of the library. |
There was a problem hiding this comment.
this feels wrong, can you give an example? I would think converting before is most correct
There was a problem hiding this comment.
There are some languages out there which have characters that don't get squished with .toLowerCase() and thus get converted to uppercase representations on our end. I don't have specific examples, and would rather avoid digging it out.
This is actually what the old room list does, it just doesn't document it.
t3chguy
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14054
For element-hq/element-web#13635