Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumping to read marker for events without tiles #4830

Closed
wants to merge 1 commit into from
Closed

Fix jumping to read marker for events without tiles #4830

wants to merge 1 commit into from

Commits on Jun 25, 2020

  1. Fix jumping to read marker for events without tiles 

    It is possible for your read marker to be set to an event without a tile (like a
reaction). We would still render the read marker at the position of those events
in the timeline, even though there's no matching tile, which breaks a core
assumption of jump to read marker path: it assumes that if the read marker node
is present in the DOM, then there must also be an event tile with a scroll token
matching the event ID.

This fixes the situation by no longer attempting to draw a read marker for
events without tiles.

Fixes element-hq/element-web#10975
    @jryans
    jryans committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    78a93bd View commit details
    Browse the repository at this point in the history