Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room List v2 context menu interactions #4870

Merged
merged 5 commits into from Jul 2, 2020
Merged

Room List v2 context menu interactions #4870

merged 5 commits into from Jul 2, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 1, 2020

@t3chguy
Fix context menu nesting causing bubbling and instabilities
89bd572 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Support right click context menu interactions on Room List 2
5c2b291 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
delint
e8702aa 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team July 1, 2020 22:10
@t3chguy
fix repeated context menu interaction by not erroring
6424ffb 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
improve default behaviour for consistency
4b27a67 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
turt2live approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine

@t3chguy t3chguy merged commit c4bbdef into develop Jul 2, 2020
@t3chguy t3chguy deleted the t3chguy/room-list/2 branch July 2, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@t3chguy @turt2live