Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handlebar interaction #4989

Merged
merged 4 commits into from Jul 28, 2020
Merged

Fix handlebar interaction #4989

merged 4 commits into from Jul 28, 2020

Conversation

JorikSchellekens
Copy link
Contributor

@JorikSchellekens JorikSchellekens requested review from a team July 16, 2020 01:13
@JorikSchellekens
Copy link
Contributor Author

@nadonomy

jryans
jryans approved these changes Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code-wise

@jryans
Copy link
Collaborator

jryans commented Jul 16, 2020

I reverted the original styles in 9b13ef1, which normally I would not do, but it will greatly simplify today's patch release, as I can take everything else form develop.

Please re-add the base commit to this PR, and let's work with Design to find out might be remaining to do here.

JorikSchellekens and others added 2 commits July 16, 2020 16:16
@JorikSchellekens
Fix handlebar interaction
d794e17
@t3chguy @JorikSchellekens
Visual WIP
5e6f8b2 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@JorikSchellekens
Copy link
Contributor Author

I really have no idea how to do this without a force push so please forgive me

@JorikSchellekens
Copy link
Contributor Author

Well, that didn't work

@JorikSchellekens
Copy link
Contributor Author

image

I think these might be too small

@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2020

They were exactly what Nad asked for, they're identical to the room list ones just rotated

@JorikSchellekens
Copy link
Contributor Author

JorikSchellekens commented Jul 28, 2020 •
edited

I got designs ok for this from Nique. Merging

@JorikSchellekens JorikSchellekens merged commit 4f55ef6 into develop Jul 28, 2020
@JorikSchellekens JorikSchellekens removed the request for review from a team July 28, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JorikSchellekens @jryans @t3chguy