-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Room List filtering visual tweaks #5123
Conversation
…-org/matrix-react-sdk into t3chguy/room-list/14466
Overall, looks good. Some minor design comments: Explore icon and text seem to be different link elements.Really small thing but it makes them a bit harder to use. If difficult, don't think it's super important at all. Font-weightsTrying to minimise the amount of font-weights used arbitrarily, unfortunately Figma is behind in this regard. Sorry about that Margins.mx_LeftPanel .mx_LeftPanel_roomListContainer .mx_LeftPanel_roomListFilterCount margin-top 14px works better than 16px in practice. I'll make a note to update figma later this week. Not necessarily relevant to this issue but noting anyway:
|
Agreed, that was done during rebranding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Based on #5118Requires element-hq/element-web#14983
Fixes element-hq/element-web#14466
Build at http://riots.im/adhoc/room-list-filtering1/