Fix right panel for peeking rooms #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
turt2live
approved these changes
Oct 2, 2020
| @@ -118,6 +118,7 @@ export default class WidgetStore extends AsyncStoreWithClient<IState> { | |||
| } | |||
|
|
|||
| private loadRoomWidgets(room: Room) { | |||
| if (!room) return; | |||
There was a problem hiding this comment.
would be good to link to element-hq/element-web#8933 as the user is a guest when peeking
There was a problem hiding this comment.
I don't think this null-guard has anything to do with that however, given that peeking guests have valid rooms too.
I saw a getRooms() call return [null] which is what I am guarding against here.
There was a problem hiding this comment.
uh, that sounds like a larger problem that shouldn't be resolved in the depths of the widget code - that'll break the room list and pretty much everything else too.
There was a problem hiding this comment.
Indeed, I hit it once and could not repro the next 10x times. This is the only error log that came of it however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#15349