fireworks effect #5507
Merged
fireworks effect #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Dec 19, 2020
Comment on lines
+72
to
+76
| maxCount: number, | ||
| /** | ||
| * gravity value that firework adds to shift from it's start position | ||
| */ | ||
| gravity: number, |
There was a problem hiding this comment.
for definitions of types and interfaces we use semicolons on the lines rather than commas - I'll fix this before merging.
|
Github is a bit weird in how it counts the merge, but the merge was actually in fa02630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for all who wants to spread the joy and still celebrate together in these times with enough safe distance and no face masks, "remotely" and throw some fireworks with no harmful damages on our climate.... this pull request does that! 馃巻
the fireworks effects can be thrown by: