Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add look of dissaproval command #5726

Closed
wants to merge 1 commit into from

Conversation

markfeathers
Copy link

@markfeathers markfeathers commented Mar 8, 2021

Adds the look of dissaproval ಠ_ಠ.

Signed-off-by: Mark Featherston mark@embeddedarm.com


Here's what your changelog entry will look like:

✨ Features

@t3chguy
Copy link
Member

t3chguy commented Mar 8, 2021

You need to run the i18n script to fix the failing tests

@t3chguy t3chguy requested a review from a team March 8, 2021 09:36
@robintown
Copy link
Member

Also needs to integrate changes from #5686

@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Apr 29, 2022
@karlabbott karlabbott added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 18, 2022
@daniellekirkwood daniellekirkwood requested review from karlabbott and removed request for a team July 18, 2022 14:53
Copy link

@karlabbott karlabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an Element product stand point, we have reviewed this request and have no problem adding another "text effect". We have also started documentation cataloging the current set of text effects: https://github.com/vector-im/element-meta/blob/develop/docs/text_effects.md.

As @robintown and @t3chguy mentioned in the comments, the i18n script needs to be run against this to fix the failing tests and the changes from #5686 need to be integrated inte this PR before it can be brought into Element Web.

Once these changes have been addressed, please add the look of disapproval to Element!

@andybalaam
Copy link
Contributor

No activity on this, but changes were still needed, so closing for now. We actually would prefer to add a user-specific snippets feature rather than adding lots of product-wide effects like this, so we don't feel too urgent on this.

@andybalaam andybalaam closed this Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants