Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer and privacy note to the start dm dialog #6111

Merged
merged 14 commits into from
Jun 14, 2021
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 27, 2021

@t3chguy t3chguy marked this pull request as draft May 27, 2021 14:52
@niquewoodhouse
Copy link
Contributor

niquewoodhouse commented May 28, 2021

Great, thanks. As we've added something to the bottom of the dialog, but it's stayed the same height, the vertical space is a bit more precious, these tweaks helped me:

  • mx_InviteDialog_helpText have margin-top 0
  • I gave too little margin to the mx_InviteDialog_footer h3 (12 instead of 8)
  • .mx_InviteDialog_userSections margin-top 4
  • .mx_InviteDialog_userSections padding-bottom 4
  • Introduce a userSections class specific for the Some results may be hidden for privacy section with padding-top 8 and padding-bottom 16, margin-left 18 (so it lines up with 'show more')
  • .mx_InviteDialog_userSections height (calc(100% - 175px)
  • mx_light-fg-color border for the link field instead of input-border-color (in practice, it standing out a bit is good)

These changes seem to give us back almost all of the people/results:

image

I didn't realise the Some results may be hidden for privacy section would appear if you're not searching. Results doesn't make sense if it's not a search, but we can just change the copy to say suggestions and it works fine.

Thanks


@nadonomy there's some specific paddings on the invite dialog to pad the content on the left and the right, so the list of people is less wide

image

Do you mind if it changes to have no bespoke padding, would just line up a bit neater as there's a full width thing at the bottom of the dialog now.

image

res/css/views/dialogs/_InviteDialog.scss Outdated Show resolved Hide resolved
res/css/views/dialogs/_InviteDialog.scss Outdated Show resolved Hide resolved
res/css/views/dialogs/_InviteDialog.scss Outdated Show resolved Hide resolved
res/css/views/dialogs/_InviteDialog.scss Outdated Show resolved Hide resolved
@t3chguy t3chguy marked this pull request as ready for review June 3, 2021 12:39
@t3chguy t3chguy requested review from a team June 3, 2021 12:39
@niquewoodhouse
Copy link
Contributor

Review

  • The 'copied' tooltip/feedback seems to stay visible after you close the dialog
  • This change appears to impact the size of the non-DM invite dialog (eg invite to this room)
    image

Can that be undone easily enough as it wasn't intended as part of this papercut?

… t3chguy/fix/17365

� Conflicts:
�	src/components/views/dialogs/InviteDialog.tsx
@turt2live
Copy link
Member

@t3chguy can we get screenshots of what it looks like in code to the PR description please?

Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshots in the PR description please to make CSS review easier :)

src/components/views/dialogs/InviteDialog.tsx Outdated Show resolved Hide resolved
src/components/views/dialogs/InviteDialog.tsx Outdated Show resolved Hide resolved
src/components/views/dialogs/InviteDialog.tsx Outdated Show resolved Hide resolved
@t3chguy t3chguy requested a review from turt2live June 8, 2021 18:07
… t3chguy/fix/17365

� Conflicts:
�	src/components/views/dialogs/InviteDialog.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve sharing self when creating a DM Improve starting a DM when no results are returned
3 participants