-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add footer and privacy note to the start dm dialog #6111
Conversation
Great, thanks. As we've added something to the bottom of the dialog, but it's stayed the same height, the vertical space is a bit more precious, these tweaks helped me:
These changes seem to give us back almost all of the people/results: I didn't realise the Thanks @nadonomy there's some specific paddings on the invite dialog to pad the content on the left and the right, so the list of people is less wide Do you mind if it changes to have no bespoke padding, would just line up a bit neater as there's a full width thing at the bottom of the dialog now. |
…t-sdk into t3chguy/fix/17365
… t3chguy/fix/17365 � Conflicts: � src/components/views/dialogs/InviteDialog.tsx
… t3chguy/fix/17365 � Conflicts: � src/components/views/dialogs/InviteDialog.tsx
@t3chguy can we get screenshots of what it looks like in code to the PR description please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screenshots in the PR description please to make CSS review easier :)
… t3chguy/fix/17365 � Conflicts: � src/components/views/dialogs/InviteDialog.tsx
Fixes element-hq/element-web#17365
Fixes element-hq/element-web#17359