Look up email addresses in ChatInviteDialog #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So email addresses known to the IS get a display name & avatar
richvdh
reviewed
Jan 26, 2017
| this._lookupThreepid(addrType, query).then((res) => { | ||
| if (res !== null) { | ||
| this.setState({ | ||
| queryList: [res] |
There was a problem hiding this comment.
why not do this in _lookupThreepid?
| @@ -435,6 +445,39 @@ module.exports = React.createClass({ | |||
| return inviteList; | |||
| }, | |||
|
|
|||
| _lookupThreepid(medium, address) { | |||
richvdh
reviewed
Jan 26, 2017
| // wait a bit to let the user finish typing | ||
| return q.delay(500).then(() => { | ||
| // If the query has changed, forget it | ||
| if (this.state.queryList[0] && this.state.queryList[0].address !== address) { |
There was a problem hiding this comment.
I sort-of wonder if it would be better to set a flag when we are changing the addresslist, rather than do this the whole time: basically rolling your own promise cancellation.
something like:
_lookupThreepid: function (medium, address) {
let cancelled = false;
this.cancelThreepidLookup = function() {
cancelled = true;
}
return q.delay(500).then(() => {
if (cancelled) { return null }
...
}) /* ... */ .finally(() => { this.cancelThreepidLookup = null })
}
then call cancelThreepidLookup in onQueryChanged
There was a problem hiding this comment.
Done, but note you can't remove cancelThreepidLookup from this in the finally because you don't know that it's the same one you added.
rather than checking queryList each time
|
ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So email addresses known to the IS get a display name & avatar
Requires element-hq/element-web#3064