Update muting in calls to work with the js-sdk call upgrade changes #6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes element-hq/element-web#12646? |
Yeah, I mainly wanted to put the thing on GH and I didn't bother doing that :D |
SimonBrandner
added
the
T-Enhancement
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
393ed0e
to
3962bd4
Compare
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
7 times, most recently
from
c106337
to
cbb94af
Compare
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
3 times, most recently
from
e18cf34
to
4ad830e
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
4ad830e
to
a2977f5
Compare
SimonBrandner
changed the title
SimonBrandner
added
T-Task
SimonBrandner
force-pushed
the
feature/call-upgrades
branch
from
5016919
to
a2977f5
Compare
turt2live
approved these changes
Sep 18, 2021
|
(thank you for the reminder - I honestly thought I'd be smart enough to merge based on the js-sdk PR, but apparently not) |
We need some automatic way to do this anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: task
Requires matrix-org/matrix-js-sdk#1827
This is not call upgrade support
Since design is busy with other stuff I've decided to land call upgrade support in the js-sdk without support in Element. Once this lands we can experiment with call upgrades in group calls and similar things
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6146cf49d86da16b8d552342--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.