Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert /src/components/views/elements to TS #6815

Merged
merged 20 commits into from
Sep 21, 2021

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Sep 15, 2021

Type: task
Fixes element-hq/element-web#19061
Requires matrix-org/matrix-js-sdk#1927


This leaves out the group and tag components for obvious reasons. Also, Pill.js conversion is in #6398


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://6149861842a6f57b6f05ad24--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 15, 2021
@SimonBrandner SimonBrandner force-pushed the task/elements-ts branch 7 times, most recently from 6e762e6 to 1de2bd0 Compare September 17, 2021 16:10
@SimonBrandner SimonBrandner marked this pull request as ready for review September 17, 2021 16:23
@SimonBrandner SimonBrandner requested a review from a team as a code owner September 17, 2021 16:23
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner changed the title Convert /elements to TS Convert /src/components/views/elements to TS Sep 20, 2021
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good - thanks! We'll also land this after the RC.

src/components/views/elements/AppTile.tsx Outdated Show resolved Hide resolved
src/components/views/elements/AppTile.tsx Outdated Show resolved Hide resolved
src/components/views/elements/AppTile.tsx Outdated Show resolved Hide resolved
src/components/views/elements/EditableTextContainer.tsx Outdated Show resolved Hide resolved
src/components/views/elements/LazyRenderList.tsx Outdated Show resolved Hide resolved
src/components/views/elements/PowerSelector.tsx Outdated Show resolved Hide resolved
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@turt2live turt2live merged commit 2eea606 into matrix-org:develop Sep 21, 2021
@SimonBrandner SimonBrandner deleted the task/elements-ts branch September 21, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert /elements to TS
2 participants