Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If public room creation fails, retry without publishing it #6872

Merged
merged 6 commits into from
Oct 12, 2021
Merged

If public room creation fails, retry without publishing it #6872

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd8a0b8
If public room creation fails, retry without publishing it (#19194)
AndrewFerr Sep 28, 2021
71851d8
Check error message for room publish failure
AndrewFerr Sep 29, 2021
017b2e0
Comment that the room publish failure check is Synapse-specific
AndrewFerr Oct 1, 2021
073c530
Close modal after re-attempt of room creation, not before
AndrewFerr Oct 3, 2021
413d6e1
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-…
AndrewFerr Oct 5, 2021
9f039b5
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…
t3chguy Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/createRoom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ export default async function createRoom(opts: IOpts): Promise<string | null> {
return client.createRoom(createOpts).finally(function() {
if (modal) modal.close();
t3chguy marked this conversation as resolved.
Show resolved Hide resolved
}).catch(function(err) {
if (err.httpStatus === 403 && err.errcode == "M_UNKNOWN") {
if (err.httpStatus === 403 && err.errcode === "M_UNKNOWN" && err.data.error === "Not allowed to publish room") {
AndrewFerr marked this conversation as resolved.
Show resolved Hide resolved
console.warn("Failed to publish room, try again without publishing it");
createOpts.visibility = Visibility.Private;
return client.createRoom(createOpts);
Expand Down