Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RequiresClient from MatrixCapabilities to ElementWidgetCapabilities #7935

Closed
wants to merge 0 commits into from

Conversation

rkouwenhoven
Copy link
Contributor

@rkouwenhoven rkouwenhoven commented Mar 1, 2022

This PR fixes element-hq/element-web#20920 by moving RequiresClient to the ElementWidgetCapabilities enum.
See also matrix-org/matrix-widget-api#54

Please add T-Task label.

Signed-off-by: Robin Kouwenhoven r.kouwenhoven@outlook.com


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://pr7935--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@rkouwenhoven rkouwenhoven requested a review from a team as a code owner March 1, 2022 19:33
@SimonBrandner SimonBrandner added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 1, 2022
@andybalaam
Copy link
Contributor

@turt2live This implements something you asked for, and looks slightly involved in terms of merging order, so probably good for you to look at.

@turt2live turt2live self-requested a review March 8, 2022 18:18
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! We'd also need to update usages of the old RequiresClient enum value, such as in the AppTile and StopGapWidgetDriver.

I'd also suggest re-opening this PR on a branch that isn't your develop branch as it can be complicated to manage the repository layering, and will break CI over time in its current setup.

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #7935 (45c3ebf) into develop (cdb0c2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7935   +/-   ##
========================================
  Coverage    29.25%   29.25%           
========================================
  Files          863      863           
  Lines        49876    49876           
  Branches     12696    12696           
========================================
  Hits         14592    14592           
  Misses       35284    35284           

@rkouwenhoven
Copy link
Contributor Author

Thanks for the change! We'd also need to update usages of the old RequiresClient enum value, such as in the AppTile and StopGapWidgetDriver.

I'd also suggest re-opening this PR on a branch that isn't your develop branch as it can be complicated to manage the repository layering, and will break CI over time in its current setup.

I reopened the PR at #8290 from a different branch. I will make the other updates later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatrixCapabilities.RequiresClient is in the wrong enum
4 participants