Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversation export named after room #7992

Closed
wants to merge 18 commits into from

Conversation

Sinharitik589
Copy link
Contributor

@Sinharitik589 Sinharitik589 commented Mar 5, 2022

Fixes element-hq/element-web#19724

Signed-off-by: Ritik Kumar sinharitik18112835@gmail.com


Here's what your changelog entry will look like:

✨ Features

Preview: https://pr7992--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@Sinharitik589 Sinharitik589 requested a review from a team as a code owner March 5, 2022 05:18
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@SimonBrandner SimonBrandner added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 5, 2022
src/utils/exportUtils/Exporter.ts Outdated Show resolved Hide resolved
src/utils/exportUtils/JSONExport.ts Outdated Show resolved Hide resolved
src/utils/exportUtils/PlainTextExport.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #7992 (e73fa9b) into develop (3e31fdb) will decrease coverage by 4.06%.
The diff coverage is 0.00%.

❗ Current head e73fa9b differs from pull request most recent head 6df5cbd. Consider uploading reports for the commit 6df5cbd to get more accurate results

@@             Coverage Diff             @@
##           develop    #7992      +/-   ##
===========================================
- Coverage    30.85%   26.79%   -4.07%     
===========================================
  Files          893      866      -27     
  Lines        50793    51950    +1157     
  Branches     12928    13163     +235     
===========================================
- Hits         15671    13918    -1753     
- Misses       35122    38032    +2910     
Impacted Files Coverage Δ
src/utils/exportUtils/Exporter.ts 10.94% <0.00%> (-0.42%) ⬇️
src/utils/exportUtils/JSONExport.ts 0.00% <0.00%> (ø)
src/utils/exportUtils/PlainTextExport.ts 27.63% <0.00%> (ø)
src/utils/read-receipts.ts 0.00% <0.00%> (-100.00%) ⬇️
src/stores/local-echo/RoomEchoContext.ts 0.00% <0.00%> (-100.00%) ⬇️
src/customisations/helpers/UIComponents.ts 0.00% <0.00%> (-100.00%) ⬇️
...list/algorithms/tag-sorting/AlphabeticAlgorithm.ts 0.00% <0.00%> (-100.00%) ⬇️
src/utils/colour.ts 0.00% <0.00%> (-94.12%) ⬇️
...c/components/views/location/LocationViewDialog.tsx 0.00% <0.00%> (-92.31%) ⬇️
src/components/views/rooms/SearchBar.tsx 0.00% <0.00%> (-89.29%) ⬇️
... and 607 more

@SimonBrandner SimonBrandner removed their request for review March 19, 2022 07:49
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member

t3chguy commented May 20, 2022

This PR contends with #8558

@kittykat kittykat self-assigned this May 20, 2022
@MadLittleMods MadLittleMods added the Z-Community-PR Issue is solved by a community member's PR label Jun 1, 2022
@kittykat
Copy link
Contributor

Apologies for slow followup. After discussing with Michael, we decided that we would like to proceed with this PR and will request for the competing PR to be split up and cover the time format in the filename.

@turt2live
Copy link
Member

Thanks for the PR! Sorry it took so long to get considered. We've decided to merge the changes from this and #9142 into a single PR to ease the requirements raised by the Product team, and are closing this PR as a result. Hopefully this should mean the code goes live soon.

You can see the new PR here: #9440

@turt2live turt2live closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

room conversation exports should name the file after the room being exported
6 participants