Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry fixing buttons alignment of Space list header #8080

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Retry fixing buttons alignment of Space list header #8080

merged 1 commit into from
Mar 18, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 18, 2022

Closes element-hq/element-web#21463

  • Move min-height property

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Follow-up to #8047

Before:

before.mp4

After:

after.mp4

Notes: none
element-web notes: none


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://pr8080--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Closes element-hq/element-web#21463

- Move min-height property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul requested a review from a team as a code owner March 18, 2022 08:17
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #8080 (d02a7df) into develop (4e4ce65) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #8080   +/-   ##
========================================
  Coverage    27.12%   27.12%           
========================================
  Files          868      868           
  Lines        52097    52097           
  Branches     13199    13199           
========================================
  Hits         14130    14130           
  Misses       37967    37967           

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live merged commit cec6a76 into matrix-org:develop Mar 18, 2022
@luixxiul luixxiul deleted the SpaceHierarchy branch March 18, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space room list header covers the list
2 participants