Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarise profile changes in MELS #826

Merged
merged 2 commits into from Apr 24, 2017
Merged

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Apr 23, 2017

@ara4n
Copy link
Member Author

ara4n commented Apr 23, 2017

@lukebarnard1 the MELS code is a thing of beauty and a joy to hack on :D

{
return 'changed_avatar';
}
console.info("MELS ignoring duplicate membership join event");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks spammy but if we really need this, I'd prefer console.log

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Apr 24, 2017

@ara4n thanks, @richvdh and I put a lot of work into it 😄

LGTM apart from one little thing

@lukebarnard1 lukebarnard1 assigned ara4n and unassigned lukebarnard1 Apr 24, 2017
@ara4n
Copy link
Member Author

ara4n commented Apr 24, 2017

sorted; thanks.

@ara4n ara4n merged commit 29e48d1 into develop Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collapse display name changes
2 participants