-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw error to analytics E2E error event context #8447
Add raw error to analytics E2E error event context #8447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit difficult to review this with failing CI
Codecov Report
@@ Coverage Diff @@
## develop #8447 +/- ##
===========================================
- Coverage 30.85% 30.78% -0.08%
===========================================
Files 893 893
Lines 50793 50775 -18
Branches 12928 12923 -5
===========================================
- Hits 15671 15629 -42
- Misses 35122 35146 +24
|
8d7a6b9
to
958c01b
Compare
Yep sry @turt2live |
SonarQube can be ignored |
(fixing sonar check) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related to element-hq/element-meta#224
Currently most of errors reported by EW are UnknownError.
We need to get more information on what the actual underlying error is.
This PR is adding the raw error as part of the context of the analytic event.
This is a quick first step to get us more information. We will transition next to a new dedicated Error Event for E2EE
This change is marked as an internal change (Task), so will not be included in the changelog.