Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw error to analytics E2E error event context #8447

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Apr 29, 2022

Related to element-hq/element-meta#224

Currently most of errors reported by EW are UnknownError.
We need to get more information on what the actual underlying error is.

This PR is adding the raw error as part of the context of the analytic event.
This is a quick first step to get us more information. We will transition next to a new dedicated Error Event for E2EE


This change is marked as an internal change (Task), so will not be included in the changelog.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner April 29, 2022 11:50
@github-actions github-actions bot temporarily deployed to Netlify April 29, 2022 11:55 Destroyed
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit difficult to review this with failing CI

@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 12:14 Destroyed
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #8447 (8d7a6b9) into develop (3e31fdb) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 8d7a6b9 differs from pull request most recent head e536412. Consider uploading reports for the commit e536412 to get more accurate results

@@             Coverage Diff             @@
##           develop    #8447      +/-   ##
===========================================
- Coverage    30.85%   30.78%   -0.08%     
===========================================
  Files          893      893              
  Lines        50793    50775      -18     
  Branches     12928    12923       -5     
===========================================
- Hits         15671    15629      -42     
- Misses       35122    35146      +24     
Impacted Files Coverage Δ
src/DecryptionFailureTracker.ts 66.66% <100.00%> (ø)
src/components/views/rooms/SearchBar.tsx 0.00% <0.00%> (-89.29%) ⬇️
src/components/views/rooms/ReadReceiptGroup.tsx 8.33% <0.00%> (-21.67%) ⬇️
src/events/EventTileFactory.tsx 66.66% <0.00%> (-0.36%) ⬇️
src/contexts/RoomContext.ts 100.00% <0.00%> (ø)
src/components/structures/RoomView.tsx 29.65% <0.00%> (ø)
src/components/views/right_panel/UserInfo.tsx 29.23% <0.00%> (ø)
src/Lifecycle.ts 1.42% <0.00%> (+<0.01%) ⬆️
...gs/handlers/AbstractLocalStorageSettingsHandler.ts 76.31% <0.00%> (+1.31%) ⬆️

@BillCarsonFr BillCarsonFr force-pushed the bca/decryption_failure_tracker_context branch from 8d7a6b9 to 958c01b Compare May 2, 2022 12:19
@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 12:24 Destroyed
@BillCarsonFr
Copy link
Member Author

it's a bit difficult to review this with failing CI

Yep sry @turt2live
I fixed the code style issues. I rebased and it did fix the e2e failing test.
But there still the SonarQube check failing, not sure what to do, it says Set the SONAR_TOKEN env variable.

@turt2live
Copy link
Member

SonarQube can be ignored

@turt2live turt2live self-requested a review May 2, 2022 15:02
@t3chguy
Copy link
Member

t3chguy commented May 2, 2022

(fixing sonar check)

@github-actions github-actions bot temporarily deployed to Netlify May 2, 2022 22:33 Destroyed
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 5, 2022
@turt2live turt2live merged commit 07d8070 into matrix-org:develop May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants