Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Use Case Selection screen #8984

Merged
merged 32 commits into from Jul 13, 2022
Merged

Implement Use Case Selection screen #8984

merged 32 commits into from Jul 13, 2022

Conversation

justjanne
Copy link
Contributor

@justjanne justjanne commented Jul 4, 2022 •
edited by github-actions bot

Type: Enhancement
Related: element-hq/element-web#22463

Here's what your changelog entry will look like:

✨ Features

@justjanne justjanne added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 4, 2022
@justjanne justjanne changed the title Initial attempt at building a use case selection screen Implement Use Case Selection screen Jul 4, 2022
@justjanne justjanne force-pushed the justjanne/feat/use-case-selection branch from 3c4e54e to b8f058f Compare July 4, 2022 14:21
@justjanne justjanne force-pushed the justjanne/feat/use-case-selection branch from 6f4ef0a to 1774aee Compare July 6, 2022 10:41
@justjanne justjanne force-pushed the justjanne/feat/use-case-selection branch from 9128a99 to 354e046 Compare July 6, 2022 13:35
@justjanne
Copy link
Contributor Author

Just to ask, is modifying other parts ok to do?

Sure, but I’d prefer if that’d be a separate issue and accordingly a separate pull request.

@turt2live
Copy link
Member

Generally this lgtm, but it doesn't seem to be informing anything yet? Should this be behind a labs flag while we build out the stuff that uses the selection for something?

Our mobile apps have already implemented this screen. The primary benefit of this for now is that we immediately get the posthog metrics of which group a user belongs to.

Actual user-facing changes will happen with the new user onboarding checklist later on.

has Product signed off on this? I'm a bit concerned it affects the user experience in a net-negative way to not have follow up questions at the moment.

turt2live
turt2live reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the missing comment and possible product signoff, lgtm

@daniellekirkwood
Copy link

Generally this lgtm, but it doesn't seem to be informing anything yet? Should this be behind a labs flag while we build out the stuff that uses the selection for something?

Our mobile apps have already implemented this screen. The primary benefit of this for now is that we immediately get the posthog metrics of which group a user belongs to.
Actual user-facing changes will happen with the new user onboarding checklist later on.

has Product signed off on this? I'm a bit concerned it affects the user experience in a net-negative way to not have follow up questions at the moment.

Yep! 👍 Thanks, @turt2live. We want to better understand the actions of users coming in to Element and will use that knowledge to ensure that when we personalise product based on the users answer to this question we get the personalisation right. It should be temporary and not a detrimental-to-experience question :)

@justjanne justjanne mentioned this pull request Jul 12, 2022
Open
@justjanne justjanne requested a review from turt2live July 12, 2022 11:21
@niquewoodhouse niquewoodhouse self-requested a review July 12, 2022 16:23
turt2live
turt2live approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

niquewoodhouse
niquewoodhouse approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@niquewoodhouse niquewoodhouse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. I think element-hq/element-web#22817 is something we should address before this merges because its part of that flue

@daniellekirkwood
Copy link

Thanks, this looks good. I think vector-im/element-web#22817 is something we should address before this merges because its part of that flue

I think it's something we should address but I don't see it as a blocker. We knew that the different background could cause some issues/confusion. Let's launch and take 22817 on as a bug.

@justjanne justjanne merged commit f5f7915 into develop Jul 13, 2022
@justjanne justjanne deleted the justjanne/feat/use-case-selection branch July 13, 2022 13:43
This was referenced Jul 22, 2022
Closed
Closed
Open
Open
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Aug 22, 2022
@su-ex
Merge tag 'v1.11.2' into sc
2996b7b 
* Live location share -  focus on user location on list item click ([\#9051](matrix-org/matrix-react-sdk#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\#9071](matrix-org/matrix-react-sdk#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\#9097](matrix-org/matrix-react-sdk#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\#9004](matrix-org/matrix-react-sdk#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\#9086](matrix-org/matrix-react-sdk#9086)).
* Use "frequently used emojis" for autocompletion in composer ([\#8998](matrix-org/matrix-react-sdk#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\#9068](matrix-org/matrix-react-sdk#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\#9037](matrix-org/matrix-react-sdk#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\#8842](matrix-org/matrix-react-sdk#8842)).
* Implement Use Case Selection screen ([\#8984](matrix-org/matrix-react-sdk#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\#9047](matrix-org/matrix-react-sdk#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\#9031](matrix-org/matrix-react-sdk#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\#8907](matrix-org/matrix-react-sdk#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\#9088](matrix-org/matrix-react-sdk#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\#9087](matrix-org/matrix-react-sdk#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\#9095](matrix-org/matrix-react-sdk#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\#9058](matrix-org/matrix-react-sdk#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\#9075](matrix-org/matrix-react-sdk#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\#9062](matrix-org/matrix-react-sdk#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\#9063](matrix-org/matrix-react-sdk#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\#9055](matrix-org/matrix-react-sdk#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this pull request Aug 22, 2022
@su-ex
Merge tag 'v3.51.0' into sc
8cb2754 
* Live location share -  focus on user location on list item click ([\matrix-org#9051](matrix-org#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\matrix-org#9071](matrix-org#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\matrix-org#9097](matrix-org#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\matrix-org#9004](matrix-org#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\matrix-org#9086](matrix-org#9086)).
*  Use "frequently used emojis" for autocompletion in composer ([\matrix-org#8998](matrix-org#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\matrix-org#9068](matrix-org#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\matrix-org#9037](matrix-org#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\matrix-org#8842](matrix-org#8842)).
* Implement Use Case Selection screen ([\matrix-org#8984](matrix-org#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\matrix-org#9047](matrix-org#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\matrix-org#9031](matrix-org#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\matrix-org#8907](matrix-org#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\matrix-org#9088](matrix-org#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\matrix-org#9087](matrix-org#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\matrix-org#9095](matrix-org#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\matrix-org#9058](matrix-org#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\matrix-org#9075](matrix-org#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\matrix-org#9062](matrix-org#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\matrix-org#9063](matrix-org#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\matrix-org#9055](matrix-org#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@niquewoodhouse niquewoodhouse niquewoodhouse approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjanne @niquewoodhouse @turt2live @daniellekirkwood