Initial Electron Settings - for Auto Launch #920
Conversation
(opens path for Proxy Settings) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Can one of the admins verify this patch? |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
| return "Not implemented"; | ||
| } | ||
|
|
||
| isElectron(): boolean { return false; } |
There was a problem hiding this comment.
this feels a bit weird to pollute BasePlatform with knowledge of electron - could we not just check the type of PlatformPeg to see if it's a VectorBasePlatform or not?
There was a problem hiding this comment.
how do you mean? I can't do PlatformPeg.get() instanceof ElectronPlatform from the react-sdk side of things. How about a generic getFlags() method on BasePlatform and descendants that would have a prop of isElectron = true on Electron Platform, no idea what else it'd be useful for but it seems like the most generic way of solving this
There was a problem hiding this comment.
or since now they have getHumanReadableName could do it based off of that but that feels dirty
There was a problem hiding this comment.
it could also just be a property and then accessed as PlatformPeg.get().isElectron
that way no other classes have to implement it but is also weird, I guess its all weird with the current settings architecture
There was a problem hiding this comment.
i must be missing how instanceof works - why wouldn't it work from the react-sdk side?
There was a problem hiding this comment.
how would I import ElectronPlatform from riot-web into react-sdk so I can refer to it in an instanceof? Am I missing something obvious :/?
There was a problem hiding this comment.
only by violating the layering (which already happens in a bunch of places, sadly). for now, stick with the isElectron() method.
|
lgtm other than query |
… t3chguy/electron_settings
t3chguy
force-pushed
the
t3chguy/electron_settings
branch
from
ed57a37
to
7e02977
Compare
ara4n
added
the
X-Release-Blocker
| const {ipcRenderer} = require('electron'); | ||
|
|
||
| return <div> | ||
| <h3>Electron Settings</h3> |
There was a problem hiding this comment.
Users don't know what electron is. "Desktop-specific settings" perhaps?
|
lgtm other than merge conflicts and the comedy setting label problem |
|
(oh, and please can haz i18n) |
|
oh hah, I half i18n'd it |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
… t3chguy/electron_settings # Conflicts: # src/components/structures/UserSettings.js # src/i18n/strings/en_EN.json First time using JetBrains Merge Tool, MAY HAVE GONE HORRIBLY WRONG Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
lgtm |
added
.isElectron()to make the detection of electron more readable