New group call experience: Room header call buttons #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robintown
added
the
T-Enhancement
By not invoking the initializing function on every render
By not calling WidgetStore on every render
Currently has no effect, but in the future this will signal to RoomView to show the call or call lobby.
As documented in element-web, this will tell the app to use Element Call exclusively for calls, disabling Jitsi and legacy 1:1 calls.
So that the UI can know when placeCall completes
Since RoomView doesn't do anything with viewingCall yet, these buttons won't have any effect when starting native group calls, but the logic is at least all there and ready to be hooked up.
robintown
force-pushed
the
ngce-start-buttons
branch
from
b499c88
to
dd1de51
Compare
| @@ -76,7 +76,7 @@ const Button: React.FC<IButtonProps> = ({ children, className, onClick }) => { | |||
| }; | |||
|
|
|||
| export const useWidgets = (room: Room) => { | |||
| const [apps, setApps] = useState<IApp[]>(WidgetStore.instance.getApps(room.roomId)); | |||
| const [apps, setApps] = useState<IApp[]>(() => WidgetStore.instance.getApps(room.roomId)); | |||
There was a problem hiding this comment.
Is this going to ignore the room changing? Why would we want that?
(am I forgetting something about this React feature again? 😅)
There was a problem hiding this comment.
room changing is accounted for by the useEffect(updateApps, [room, updateApps]); line after this. My only reason for this change was optimization, so that getApps doesn't get called on every render.
odelcroi
added a commit
to tchapgouv/tchap-web-v4
that referenced
this pull request
Oct 5, 2022
* Device manager - select all devices ([\#9330](matrix-org/matrix-react-sdk#9330)). Contributed by @kerryarchibald. * New group call experience: Call tiles ([\#9332](matrix-org/matrix-react-sdk#9332)). * Add Shift key to FormatQuote keyboard shortcut ([\#9298](matrix-org/matrix-react-sdk#9298)). Contributed by @owi92. * Device manager - sign out of multiple sessions ([\#9325](matrix-org/matrix-react-sdk#9325)). Contributed by @kerryarchibald. * Display push toggle for web sessions (MSC3890) ([\#9327](matrix-org/matrix-react-sdk#9327)). * Add device notifications enabled switch ([\#9324](matrix-org/matrix-react-sdk#9324)). * Implement push notification toggle in device detail ([\#9308](matrix-org/matrix-react-sdk#9308)). * New group call experience: Starting and ending calls ([\#9318](matrix-org/matrix-react-sdk#9318)). * New group call experience: Room header call buttons ([\#9311](matrix-org/matrix-react-sdk#9311)). * Make device ID copyable in device list ([\#9297](matrix-org/matrix-react-sdk#9297)). Contributed by @duxovni. * Use display name instead of user ID when rendering power events ([\#9295](matrix-org/matrix-react-sdk#9295)). * Read receipts for threads ([\#9239](matrix-org/matrix-react-sdk#9239)). Fixes #23191. * Fix device selection in pre-join screen for Element Call video rooms ([\#9321](matrix-org/matrix-react-sdk#9321)). Fixes #23331. * Don't render a 1px high room topic if the room topic is empty ([\#9317](matrix-org/matrix-react-sdk#9317)). Contributed by @Arnei. * Don't show feedback prompts when that UIFeature is disabled ([\#9305](matrix-org/matrix-react-sdk#9305)). Fixes #23327. * Fix soft crash around unknown room pills ([\#9301](matrix-org/matrix-react-sdk#9301)). Fixes matrix-org/element-web-rageshakes#15465. * Fix spaces feedback prompt wrongly showing when feedback is disabled ([\#9302](matrix-org/matrix-react-sdk#9302)). Fixes #23314. * Fix tile soft crash in ReplyInThreadButton ([\#9300](matrix-org/matrix-react-sdk#9300)). Fixes matrix-org/element-web-rageshakes#15493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Labs flag for the 'New group call experience', and as a first step, updates the call buttons in the room header to the latest designs, without fully hooking them up to RoomView just yet.
Part of element-hq/element-web#23107
Depends on element-hq/element-web#23344
Here's what your changelog entry will look like:
✨ Features