Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use icon component instead of mask-image for formatting buttons #9732

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Use icon component instead of mask-image for formatting buttons #9732

merged 3 commits into from
Dec 9, 2022

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Dec 9, 2022 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

The purpose here is to use the icon component instead of mask-image for the formatting buttons.

See here https://github.com/matrix-org/matrix-react-sdk/blob/develop/docs/icons.md

With mask-image

Screenshot 2022-12-09 at 15 56 46

With icon component

Screenshot 2022-12-09 at 15 56 11

Recording with icon components:

Screen.Recording.2022-12-09.at.15.53.52.mov

This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 9, 2022
@florianduros florianduros changed the title Add icon component instead of mask-image Add icon component instead of mask-image for formatting buttons Dec 9, 2022
@florianduros florianduros marked this pull request as ready for review December 9, 2022 15:13
@florianduros florianduros requested a review from a team as a code owner December 9, 2022 15:13
@florianduros florianduros changed the title Add icon component instead of mask-image for formatting buttons Use icon component instead of mask-image for formatting buttons Dec 9, 2022
germain-gg
germain-gg approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ship it

@florianduros florianduros merged commit dec72c7 into develop Dec 9, 2022
@florianduros florianduros deleted the tech/use-icon-instead-of-mask-image branch December 9, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@turt2live turt2live Awaiting requested review from turt2live turt2live is a code owner automatically assigned from matrix-org/element-web-reviewers

@alunturner alunturner Awaiting requested review from alunturner alunturner is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florianduros @germain-gg