Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use compound colours for verification badges #9794

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Use compound colours for verification badges #9794

merged 4 commits into from
Dec 20, 2022

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Dec 19, 2022 •
edited by github-actions bot
Loading

  • Update e2e- style variables to use compound red and green
  • Use e2e variables for shield styles

Before:
Screenshot 2022-12-19 at 19 30 05

After:
Screenshot 2022-12-19 at 19 20 32

No visual change:
Screenshot 2022-12-19 at 19 28 09
Screenshot 2022-12-19 at 19 27 21
Screenshot 2022-12-19 at 19 27 08
Screenshot 2022-12-19 at 19 21 48
Screenshot 2022-12-19 at 19 21 37

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 19, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner December 19, 2022 06:31
@germain-gg germain-gg removed their request for review December 19, 2022 08:44
@kerryarchibald kerryarchibald enabled auto-merge (squash) December 20, 2022 00:32
@kerryarchibald kerryarchibald merged commit d3ab119 into develop Dec 20, 2022
@kerryarchibald kerryarchibald deleted the psg-1103/compound-colors-for-verificaiton branch December 20, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kerryarchibald @weeman1337