[Backport staging] Prevent unnecessary m.direct updates #9817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent unnecessary m.direct updates Signed-off-by: Michael Weimann <michaelw@matrix.org> * Replace object with Map * Clean up comment; simplify code * Fix rte flaky test (#9811) * Snap in PiP widget when content changed (#9797) * Check modified at the end of setDMRoom * Revert "Snap in PiP widget when content changed (#9797)" This reverts commit be1e575. * Revert "Fix rte flaky test (#9811)" This reverts commit 20d9eb3. * Update src/Rooms.ts Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Signed-off-by: Michael Weimann <michaelw@matrix.org> Co-authored-by: Florian Duros <florianduros@element.io> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> (cherry picked from commit 93dd010)
RiotRobot
requested review from
richvdh and
robintown
and removed request for
a team
RiotRobot
added
T-Defect
github-actions
bot
added
the
Z-Community-PR
richvdh
approved these changes
Dec 21, 2022
|
test failures expected - holding back until develop CI for the change passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 93dd010 from #9805.
Here's what your changelog entry will look like:
馃悰 Bug Fixes