Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jonas Platte <jplatte@element.io>
  • Loading branch information
gnunicorn and jplatte committed May 2, 2022
1 parent a7b8cc5 commit d1aa463
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/style.yml
@@ -1,4 +1,4 @@
name: Style checker
name: Style

on:
workflow_dispatch:
Expand All @@ -16,9 +16,8 @@ env:
CARGO_TERM_COLOR: always

jobs:

style:
name: Check Format
name: Check Formatting
runs-on: ubuntu-latest
if: github.event_name == 'push' || !github.event.pull_request.draft

Expand All @@ -41,7 +40,7 @@ jobs:
args: -- --check

pre-commit-styles:
name: Checking Styles
name: Check Style
if: github.event_name == 'push' || !github.event.pull_request.draft
runs-on: ubuntu-latest
steps:
Expand All @@ -65,7 +64,6 @@ jobs:
# only run `commit`-hooks, excludes typos, clippy, etc
extra_args: --show-diff-on-failure --hook-stage commit


typos:
name: Spell Check with Typos
needs: [style]
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Expand Up @@ -35,7 +35,7 @@ repos:

- id: typos
name: typos
stages: [ push ]
stages: [push]
language: system
entry: typos
pass_filenames: false
2 changes: 1 addition & 1 deletion xtask/src/fixup.rs
Expand Up @@ -14,7 +14,7 @@ pub struct FixupArgs {

#[derive(Subcommand)]
enum FixupCommand {
/// Check style
/// Fix style
Style,
/// Check for typos
Typos,
Expand Down

0 comments on commit d1aa463

Please sign in to comment.