Switch the FFI bindings to use the SQLite cryptostore #1711
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1711 +/- ##
=======================================
Coverage 76.14% 76.14%
=======================================
Files 137 137
Lines 15222 15222
=======================================
Hits 11591 11591
Misses 3631 3631 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
|
||
| let state_store = state_store.build()?; | ||
|
|
||
| let crypto_store = RUNTIME.block_on(matrix_sdk_sqlite::SqliteCryptoStore::open( |
There was a problem hiding this comment.
Maybe this method should be called something along the lines of configureWithPath if it does both creation and opening
There was a problem hiding this comment.
When you say creation, you mean creation of the DB or the SqliteCryptoStore object?
If the former, you can't create a SQLite DB without opening it. If the later what's the point of having the object if it's unable to do anything except call a build() or open() method.
Note that the open method is somewhat idiomatic in the SQLite context: https://docs.rs/rusqlite/latest/rusqlite/struct.Connection.html#method.open.
There was a problem hiding this comment.
Note that the open method is somewhat idiomatic in the SQLite context
Right okay, that explains it
|
|
||
| let state_store = state_store.build()?; | ||
|
|
||
| let crypto_store = RUNTIME.block_on(matrix_sdk_sqlite::SqliteCryptoStore::open( |
There was a problem hiding this comment.
But also, why does the sled one have a builder and this one doesn't? 🤔
There was a problem hiding this comment.
The state store is a bit more complex, i.e. you have the ability to expand the state store into a crypto store which uses the same underlying database.
In any case, once we have a SQLite state store as well, we'll add the ability to configure the SQLite store on the client builder and you won't have to access this low level interface.
Since we have no migration from Sled to SQLite we'll have to log our EX users out. cc @stefanceriu.