base: Make store requests in batch for Room::get_members

[zecakeh]

Each commit can be viewed separately. The first commits add the methods to retrieve events in batch to the StateStore trait and the last one uses the new methods for Room::get_members.

Should fix part of #1979. What is left is to be able to paginate to not request all the results at once.

• Public API changes documented in changelogs (optional)

Signed-off-by: Kévin Commaille zecakeh@tedomum.fr

[codecov]

Codecov Report

Patch coverage: 97.11% and project coverage change: +0.47 🎉

Comparison is base (eb5af42) 75.50% compared to head (21fa3e5) 75.98%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
+ Coverage   75.50%   75.98%   +0.47%     
==========================================
  Files         151      151              
  Lines       16211    16550     +339     
==========================================
+ Hits        12240    12575     +335     
- Misses       3971     3975       +4     

Impacted Files	Coverage Δ
crates/matrix-sdk/src/room/common.rs	77.12% <0.00%> (-0.58%)	⬇️
crates/matrix-sdk-base/src/store/traits.rs	73.68% <83.33%> (+1.80%)	⬆️
crates/matrix-sdk-sqlite/src/state_store.rs	91.63% <94.62%> (+1.54%)	⬆️
crates/matrix-sdk-base/src/rooms/normal.rs	71.05% <97.29%> (+0.56%)	⬆️
crates/matrix-sdk-base/src/store/memory_store.rs	86.58% <98.03%> (+1.17%)	⬆️
...ates/matrix-sdk-base/src/deserialized_responses.rs	66.12% <100.00%> (+2.33%)	⬆️
crates/matrix-sdk-base/src/rooms/members.rs	58.46% <100.00%> (+12.46%)	⬆️
...tes/matrix-sdk-base/src/store/integration_tests.rs	97.88% <100.00%> (+0.76%)	⬆️
crates/matrix-sdk-sqlite/src/utils.rs	93.47% <100.00%> (+0.29%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Hywan]

Excellent work, thank you for your time on this!

It looks good to me. Although a second review from @jplatte might not be superflous.

[jplatte]

Quick comment, might review more in-depth later.

[jplatte]

Let's get the conflicts fixed and merge this, I haven't reviewed everything but since Ivan did and this PR even increases test coverage, I don't think I need to.

[zecakeh]

Rebased on main and history cleaned up 🙂