-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timeline::retry_send #2022
Add Timeline::retry_send #2022
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
==========================================
+ Coverage 75.22% 75.24% +0.02%
==========================================
Files 147 147
Lines 16034 16076 +42
==========================================
+ Hits 12062 12097 +35
- Misses 3972 3979 +7
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, thanks!
I wish we could have a test to ensure this behavior. How hard would it be?
I guess testing shouldn't be that hard if we use HTTP mocking to make the first try fail. I'll give it a try. |
ff008df
to
eb312f4
Compare
Previously a pretty obvious hole in the timeline API: When sending failed, there was no way to deal with the failed local echo. This adds one way to do that, we should also add the ability to cancel a failed local echo (in a separate PR).