Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Add loading indicator before waiting for prev_batch token #2073

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jun 14, 2023

… in Timeline::paginate_backwards.

@jplatte jplatte requested a review from ganfra June 14, 2023 11:05
@jplatte jplatte requested a review from a team as a code owner June 14, 2023 11:05
@jplatte jplatte requested review from bnjbvr and removed request for a team June 14, 2023 11:05
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@jplatte jplatte enabled auto-merge (rebase) June 14, 2023 11:15
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (ae4ead5) 75.50% compared to head (e579ad1) 75.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2073   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files         151      151           
  Lines       16211    16211           
=======================================
  Hits        12240    12240           
  Misses       3971     3971           
Impacted Files Coverage Δ
crates/matrix-sdk-ui/src/timeline/mod.rs 82.44% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jplatte jplatte merged commit b4cd0c7 into main Jun 14, 2023
47 checks passed
@jplatte jplatte deleted the jplatte/loading-indicator branch June 14, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants