widget: move client into its own module and split the things up into own submodules
#2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return `Self` and the channel to process incoming actions.
daniel-abramov
requested review from
bnjbvr and
jplatte
and removed request for
a team and
bnjbvr
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
=======================================
Coverage 78.41% 78.41%
=======================================
Files 192 192
Lines 20099 20099
=======================================
Hits 15761 15761
Misses 4338 4338
☔ View full report in Codecov by Sentry. |
jplatte
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that one monolithic
client.rsgets smaller (necessary for the follow-up changes to keep things simpler/cleaner).This is a follow-up of a discussion here: #2677 (comment)