widget: define all possible outgoing requests #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-abramov
force-pushed
the
widget-api-outgoing-scaffolding
branch
from
97c1c7e
to
1840747
Compare
jplatte
reviewed
Oct 11, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 200 200
Lines 20349 20349
=======================================
Hits 16025 16025
Misses 4324 4324
☔ View full report in Codecov by Sentry. |
This includes the requests that are sent to the matrix client (i.e. a request to send a matrix event) as well as requests that are sent to the widget. The difference between this and `Action` is that `Action` is rather "low-level" (i.e. it has a generic `SendToWidget(String)` variant), whereas this API is a high-level API that we will use internally to conveniently issue and `await` for outgoing responses.
daniel-abramov
force-pushed
the
widget-api-outgoing-scaffolding
branch
from
1840747
to
4689173
Compare
jplatte
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though a lot of what to create next to keep it small and rather isolated, decided to try this one :) The implementation will follow.