Replace async-std with equivalent tokio functionality #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix-sdk-common and matrix-sdk-crypto were repeating things that would be inherited from the workspace dependency specification anyways.
jplatte
requested review from
bnjbvr and
poljar
and removed request for
a team and
bnjbvr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2801 +/- ##
==========================================
+ Coverage 81.36% 81.70% +0.34%
==========================================
Files 204 204
Lines 21051 21052 +1
==========================================
+ Hits 17128 17201 +73
+ Misses 3923 3851 -72
☔ View full report in Codecov by Sentry. |
richvdh
reviewed
Nov 2, 2023
jplatte
force-pushed
the
jplatte/rm-async-std
branch
from
d32dbb4
to
7ff5f45
Compare
richvdh
reviewed
Nov 2, 2023
jplatte
force-pushed
the
jplatte/rm-async-std
branch
from
7ff5f45
to
52ac8f1
Compare
jplatte
force-pushed
the
jplatte/rm-async-std
branch
from
52ac8f1
to
84f1a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to take another look at our use of async-std, and AFAICT we are not actually requiring any
Condvar-specific functionality (I think the only case where it does more than tokio'sNotifyis when a specific piece of code wants to queue up to be "next in line" to operate on the mutex after the wait condition is fulfilled).We also got a new use in an example, but that was even easier to remove.
Requesting rich's review in addition to one from the team because he added the use of
async-stdsCondvar.