Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable backups in the crypto crate by default #2813

Merged
merged 1 commit into from Nov 3, 2023
Merged

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Nov 3, 2023

This PR enables backups in the crypto crate by default and removes the
backups_v1 feature, for better or worse.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner November 3, 2023 14:43
@poljar poljar requested review from bnjbvr and removed request for a team November 3, 2023 14:43
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (beb01ea) 82.03% compared to head (a5c4098) 82.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2813      +/-   ##
==========================================
+ Coverage   82.03%   82.36%   +0.32%     
==========================================
  Files         204      208       +4     
  Lines       21024    21391     +367     
==========================================
+ Hits        17248    17618     +370     
+ Misses       3776     3773       -3     
Files Coverage Δ
crates/matrix-sdk-crypto/src/backups/mod.rs 72.92% <ø> (ø)
crates/matrix-sdk-crypto/src/gossiping/machine.rs 77.80% <ø> (+6.62%) ⬆️
crates/matrix-sdk-crypto/src/identities/device.rs 79.68% <ø> (-1.62%) ⬇️
crates/matrix-sdk-crypto/src/lib.rs 100.00% <ø> (ø)
crates/matrix-sdk-crypto/src/machine.rs 86.69% <ø> (+2.20%) ⬆️
crates/matrix-sdk-crypto/src/olm/account.rs 88.66% <ø> (+1.00%) ⬆️
...atrix-sdk-crypto/src/olm/group_sessions/inbound.rs 83.83% <ø> (+1.40%) ⬆️
crates/matrix-sdk-crypto/src/olm/utility.rs 85.00% <ø> (-4.48%) ⬇️
crates/matrix-sdk-crypto/src/store/mod.rs 87.37% <100.00%> (+1.17%) ⬆️
...atrix-sdk-crypto/src/types/cross_signing/master.rs 83.87% <ø> (ø)
... and 1 more

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

crates/matrix-sdk-crypto/src/machine.rs Outdated Show resolved Hide resolved
@poljar poljar enabled auto-merge (rebase) November 3, 2023 18:02
@poljar poljar merged commit e5b06bd into main Nov 3, 2023
35 checks passed
@poljar poljar deleted the poljar/enable-backups branch November 3, 2023 18:17
@poljar poljar self-assigned this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants