Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare our /keys/claim response handling to handle multiple OTKs #2870

Merged
merged 4 commits into from Nov 22, 2023

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Nov 21, 2023

This is useful if we ever decide to switch to X3DH for the session establishment. It also refactors a bit the /keys/claim response handling method.

This is useful if we ever decide to switch to X3DH for the session
establishment. It also refactors a bit the /keys/claim response handling
method.
@poljar poljar marked this pull request as ready for review November 22, 2023 08:18
@poljar poljar requested a review from a team as a code owner November 22, 2023 08:18
@poljar poljar requested review from Hywan and jplatte and removed request for a team and Hywan November 22, 2023 08:18
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (c7712b5) 82.45% compared to head (56c19bc) 82.46%.
Report is 1 commits behind head on main.

Files Patch % Lines
...rates/matrix-sdk-crypto/src/types/one_time_keys.rs 33.33% 8 Missing ⚠️
crates/matrix-sdk-crypto/src/olm/account.rs 80.64% 6 Missing ⚠️
.../matrix-sdk-crypto/src/session_manager/sessions.rs 93.47% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2870   +/-   ##
=======================================
  Coverage   82.45%   82.46%           
=======================================
  Files         211      211           
  Lines       21615    21639   +24     
=======================================
+ Hits        17823    17844   +21     
- Misses       3792     3795    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/matrix-sdk-crypto/src/olm/account.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/olm/account.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/session_manager/sessions.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/session_manager/sessions.rs Outdated Show resolved Hide resolved
crates/matrix-sdk-crypto/src/types/one_time_keys.rs Outdated Show resolved Hide resolved
@poljar poljar merged commit bb4254b into main Nov 22, 2023
35 checks passed
@poljar poljar deleted the poljar/find-keys-refactor branch November 22, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants