sdk: Room Directory Search #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also improved the integration test for the filtered case
Hywan
requested changes
Feb 28, 2024
testing/matrix-sdk-integration-testing/src/tests/room_directory_search.rs
Outdated
Show resolved
Hide resolved
and removed code from ffi that will be changed soon
into the check for the request
Co-authored-by: Ivan Enderlin <ivan@mnt.io> Signed-off-by: Mauro <34335419+Velin92@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
+ Coverage 83.67% 83.72% +0.04%
==========================================
Files 236 237 +1
Lines 24396 24472 +76
==========================================
+ Hits 20413 20488 +75
- Misses 3983 3984 +1 ☔ View full report in Codecov by Sentry. |
…matrix-rust-sdk into mauroromito/directory_search
Hywan
reviewed
Mar 13, 2024
improved the conversion by using a try from and changed the nex_token to a search state to indicate the current state of the search
Hywan
reviewed
Mar 14, 2024
Co-authored-by: Ivan Enderlin <ivan@mnt.io> Signed-off-by: Mauro <34335419+Velin92@users.noreply.github.com>
Hywan
approved these changes
Mar 20, 2024
Signed-off-by: Ivan Enderlin <ivan@mnt.io>
Signed-off-by: Ivan Enderlin <ivan@mnt.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a service to allow for filtered public room search with pagination.