feat(sdk): EventCache fully uses RoomEvents/LinkedChunk
#3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
4 times, most recently
from
6990ec4
to
cd3671f
Compare
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
2 times, most recently
from
9720873
to
6222bbd
Compare
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
3 times, most recently
from
7acc135
to
1f0e3b7
Compare
|
Marking the PR as Ready for review just to get the CI feedback, but it's not ready for a review :-). Everything seems in-place though, just checking. The history needs to be rewritten. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
==========================================
+ Coverage 83.56% 83.60% +0.04%
==========================================
Files 238 238
Lines 24598 24585 -13
==========================================
- Hits 20556 20555 -1
+ Misses 4042 4030 -12 ☔ View full report in Codecov by Sentry. |
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
2 times, most recently
from
30e91e6
to
be9079a
Compare
bnjbvr
requested changes
Mar 22, 2024
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
from
bf88bea
to
70fb96f
Compare
…` and `events`. This patch implements the following wrapper methods (over `LinkedChunk`): `push_gap`, `replace_gap_at` and `events`. This patch also implements the `reset` method that clears/drops all chunks in the `LinkedChunk`.
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
from
70fb96f
to
755034e
Compare
The test `test_reset_while_backpaginating` was expecting a race-condition, which no longer exists. It first initially tried to assert a workaround about this race-condition. It doesn't hold anymore. Rewrite the test to assert the (correct) new behaviour.
This patch ensures that operations on `RoomEvents` happen in one block, by sharing the same lock. 2 new methods are created: `replace_all_events_by` and `append_new_events`.
… unknown token. Prior to this patch, in `RoomEventCacheInner::backpaginate`, when the `token` validity was checked, and it was invalid: * before calling `/messages`, `Err(EventCacheError::UnknownBackpaginationToken)` was returned, * after calling `/messages`, `Ok(BackPaginationOutput::UnknownBackpaginationToken)` was returned. This patch tries to uniformize this by only returning `Ok(BackPaginationOutput::UnknownBackpaginationToken)`. That's a tradeoff. It will probably be refactor later. The idea is also to call `/messages` **before** taking the write-lock of `RoomEvents`, otherwise it can keep the lock for up to 30secs in this case. Also, checking the validity of the `token` **before** and **after** `/messages` is not necessary: it can be done only after.
Hywan
force-pushed
the
feat-sdk-event-cache-use-room-events
branch
from
755034e
to
11c3799
Compare
|
I've rewritten the entire history of this patch. I think we are good! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventCacheuses a customEventCacheStoretrait to store all events for all rooms.The idea of this PR is to use the newly introduced
LinkedChunkin #3166. Instead of having one store for all events for all rooms, now there is oneLinkedChunk/store per room.Of course, @bnjbvr and I are discussing a lot, which explains why the actual
EventCacheStorewas already adopting some patterns fromLinkedChunk. The migration was easier.Several PR were necessary to make this work possible:
LinkedChunkcan hold a value forGaps #3227LinkedChunkin fix(sdk): Various tiny improvements forLinkedChunk#3236LinkedChunkin feat(sdk): Optimise howLinkedChunk::insert_gap_atworks when inserting at first position #3251Briefly, this PR removes the
EventCacheStoreand theMemoryStore, and replace them byLinkedChunk.